Ver código fonte

fix: evt listener on the wrong element too

Sv443 1 ano atrás
pai
commit
b2e3e69db1
3 arquivos alterados com 24 adições e 12 exclusões
  1. 12 6
      dist/BetterYTM.user.js
  2. 5 6
      src/features/layout.ts
  3. 7 0
      src/features/menu/menu.ts

+ 12 - 6
dist/BetterYTM.user.js

@@ -475,7 +475,7 @@ const scriptInfo = Object.freeze({
     name: GM.info.script.name,
     version: GM.info.script.version,
     namespace: GM.info.script.namespace,
-    lastCommit: "afe4ca5", // assert as generic string instead of union
+    lastCommit: "069aba5", // assert as generic string instead of union
 });
 
 
@@ -970,6 +970,11 @@ function addConfigMenuOption(container) {
     cfgOptElem.className = "bytm-cfg-menu-option";
     const cfgOptItemElem = document.createElement("div");
     cfgOptItemElem.className = "bytm-cfg-menu-option-item";
+    cfgOptItemElem.addEventListener("click", () => {
+        const settingsBtnElem = document.querySelector("ytmusic-nav-bar ytmusic-settings-button tp-yt-paper-icon-button");
+        settingsBtnElem === null || settingsBtnElem === void 0 ? void 0 : settingsBtnElem.click();
+        (0,_menu_menu_old__WEBPACK_IMPORTED_MODULE_4__.openMenu)();
+    });
     const cfgOptIconElem = document.createElement("img");
     cfgOptIconElem.className = "bytm-cfg-menu-option-icon";
     cfgOptIconElem.src = (0,_utils__WEBPACK_IMPORTED_MODULE_2__.getAssetUrl)("icon/icon.png");
@@ -980,11 +985,6 @@ function addConfigMenuOption(container) {
     cfgOptItemElem.appendChild(cfgOptIconElem);
     cfgOptItemElem.appendChild(cfgOptTextElem);
     cfgOptElem.appendChild(cfgOptItemElem);
-    cfgOptElem.addEventListener("click", () => {
-        const settingsBtnElem = document.querySelector("ytmusic-nav-bar ytmusic-settings-button tp-yt-paper-icon-button");
-        settingsBtnElem === null || settingsBtnElem === void 0 ? void 0 : settingsBtnElem.click();
-        (0,_menu_menu_old__WEBPACK_IMPORTED_MODULE_4__.openMenu)();
-    });
     container.appendChild(cfgOptElem);
     (0,_utils__WEBPACK_IMPORTED_MODULE_2__.log)("Added BYTM-Configuration button to menu popover");
 }
@@ -1415,6 +1415,12 @@ __webpack_require__.r(__webpack_exports__);
 
 
 
+// REQUIREMENTS:
+// - modal using the <dialog> element
+// - sections with headers
+// - support for "custom widgets"
+// - debounce or save on button press to store new configuration
+// - much better scaling including no vw and vh units
 //#MARKER menu
 /**
  * These are the base selector values for the menu tabs

+ 5 - 6
src/features/layout.ts

@@ -45,6 +45,11 @@ export function addConfigMenuOption(container: HTMLElement) {
   
   const cfgOptItemElem = document.createElement("div");
   cfgOptItemElem.className = "bytm-cfg-menu-option-item";
+  cfgOptItemElem.addEventListener("click", () => {
+    const settingsBtnElem = document.querySelector<HTMLElement>("ytmusic-nav-bar ytmusic-settings-button tp-yt-paper-icon-button");
+    settingsBtnElem?.click();
+    openMenu();
+  });
 
   const cfgOptIconElem = document.createElement("img");
   cfgOptIconElem.className = "bytm-cfg-menu-option-icon";
@@ -60,12 +65,6 @@ export function addConfigMenuOption(container: HTMLElement) {
 
   cfgOptElem.appendChild(cfgOptItemElem);
 
-  cfgOptElem.addEventListener("click", () => {
-    const settingsBtnElem = document.querySelector<HTMLElement>("ytmusic-nav-bar ytmusic-settings-button tp-yt-paper-icon-button");
-    settingsBtnElem?.click();
-    openMenu();
-  });
-
   container.appendChild(cfgOptElem);
 
   log("Added BYTM-Configuration button to menu popover");

+ 7 - 0
src/features/menu/menu.ts

@@ -2,6 +2,13 @@ import changelogContent from "../../../changelog.md";
 import menuContent from "./menu.html";
 import "./menu.css";
 
+// REQUIREMENTS:
+// - modal using the <dialog> element
+// - sections with headers
+// - support for "custom widgets"
+// - debounce or save on button press to store new configuration
+// - much better scaling including no vw and vh units
+
 //#MARKER menu
 
 /**